Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node add call triggers no prompt found for local-build-path error and exits #515

Merged
merged 4 commits into from
Aug 27, 2024
Merged

fix: node add call triggers no prompt found for local-build-path error and exits #515

merged 4 commits into from
Aug 27, 2024

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • reset the disablePrompt attribute for the definition under each flag
  • add local build path to the disabled prompts for node add

Related Issues

@jeromy-cannon
reset disabled prompts before using them
d07ca19 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
don't prompt for local build path
8e464ff 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon self-assigned this Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Unit Test Results - Linux

  1 files   19 suites   45s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
152 runs  152 ✅ 0 💤 0 ❌

Results for commit 11046c9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Unit Test Results - Windows

  1 files   19 suites   1m 35s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
152 runs  152 ✅ 0 💤 0 ❌

Results for commit 11046c9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

E2E Node PEM Stop Tests Coverage Report

12 tests   12 ✅  2m 41s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 11046c9.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon changed the base branch from main to release/0.28 August 27, 2024 13:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

E2E Node PFX Kill Tests Coverage Report

12 tests   12 ✅  2m 51s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 11046c9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

E2E Relay Tests Coverage Report

1 files  1 suites   2m 41s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs  6 ✅ 0 💤 0 ❌

Results for commit 11046c9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

E2E Tests Coverage Report

57 tests   57 ✅  4m 5s ⏱️
 9 suites   0 💤
 1 files     0 ❌

Results for commit 11046c9.

♻️ This comment has been updated with latest results.

@jeromy-cannon
don't prompt for local build path
5e04edc 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

E2E Node Local Build Tests Coverage Report

8 tests   8 ✅  2m 51s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit 11046c9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

E2E Mirror Node Tests Coverage Report

 1 files   1 suites   3m 41s ⏱️
12 tests 12 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit 11046c9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

E2E Node Add Tests Coverage Report

10 tests   10 ✅  6m 36s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 11046c9.

♻️ This comment has been updated with latest results.

@jeromy-cannon
increase test timeout
11046c9 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for d5acbe31 ✅ 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d5acbe3) Report Missing Report Missing Report Missing
Head commit (11046c9) 3720 3042 81.77%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#515) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/0.28@d5acbe3). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.28     #515   +/-   ##
===============================================
  Coverage                ?   81.52%           
===============================================
  Files                   ?       35           
  Lines                   ?     4449           
  Branches                ?      757           
===============================================
  Hits                    ?     3627           
  Misses                  ?      822           
  Partials                ?        0
Files Coverage Δ
src/commands/flags.mjs 95.52% <100.00%> (ø)
src/commands/node.mjs 78.75% <ø> (ø)
src/commands/prompts.mjs 69.48% <100.00%> (ø)

Impacted file tree graph

@jeromy-cannon jeromy-cannon marked this pull request as ready for review August 27, 2024 15:43
@jeromy-cannon jeromy-cannon requested review from leninmehedy and a team as code owners August 27, 2024 15:43
@jeromy-cannon jeromy-cannon merged commit facbb21 into release/0.28 Aug 27, 2024
38 of 39 checks passed
@jeromy-cannon jeromy-cannon deleted the 00514-local-build-path-error branch August 27, 2024 17:47
jeromy-cannon added a commit that referenced this pull request Aug 27, 2024
@jeromy-cannon
fix: node add call triggers no prompt found for local-build-path erro…
2905d9d 
…r and exits (#515)

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon mentioned this pull request Aug 27, 2024
Merged
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

instamenta
instamenta reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@instamenta instamenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@instamenta instamenta instamenta left review comments

@JeffreyDallas JeffreyDallas JeffreyDallas approved these changes

@nathanklick nathanklick nathanklick approved these changes

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner

Assignees

@jeromy-cannon jeromy-cannon

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: node add call triggers no prompt found for local-build-path error and exits
5 participants
@jeromy-cannon @swirlds-automation @nathanklick @JeffreyDallas @instamenta